Conversation
… decoding are options too
|
I'll try to have a look today afternoon or tomorrow |
|
@hadrilec I'm having a look now, in the meantime, could add |
tfardet
left a comment
tfardet
left a comment
There was a problem hiding this comment.
Thanks, it's indeed more readable!
I put a few remarks.
While you're at it, if you don't mind, could you remove the update=True from get_geodata('ADMINEXPRESS-COG-CARTO.LATEST:departement', update=True)?
Optionally maybe also the not so useful head()?
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "data.to_csv('sirene.csv')" | ||
| "init_conn(sirene_key='f7345356-8301-4567-b453-568301456723')" |
There was a problem hiding this comment.
Should that really be there?
There was a problem hiding this comment.
indeed, big mistake I will have to delete the PR
There was a problem hiding this comment.
no, you have to reset the key, the data is leaked already ;)
the PR can stay, your key has to change ^^
| " else:\n", | ||
| " return pattern[0]" |
There was a problem hiding this comment.
you can use a return early pattern, here: drop the else line and just keep return pattern[0]
| " match_list = ['RENAULT SAS', 'ALPINE', 'BATILLY', 'MAUBEUGE CONSTRUCTION',\n", | ||
| " 'TOYOTA', 'STELLANTIS AUTO SAS', 'RENAULT TRUCKS']\n", | ||
| " \n", | ||
| " values = ['RENAULT SAS', 'RENAULT SAS', 'RENAULT SAS', 'RENAULT SAS',\n", |
There was a problem hiding this comment.
use a dictionary instead?
2 participants
example on carmaker fixed